Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect definition in nuget #1

Open
Wenfengcheng opened this issue Nov 12, 2018 · 1 comment · May be fixed by #2
Open

Incorrect definition in nuget #1

Wenfengcheng opened this issue Nov 12, 2018 · 1 comment · May be fixed by #2

Comments

@Wenfengcheng
Copy link

@tuyen-vuduc
I try to install Naxam.GoogleIMA.iOS into my project. But when I use it, I found that some of the classes are incorrectly defined.

E.g
Here is the definition in nuget：

    [Register("IMAAVPlayerContentPlayhead", true)]
    public class IMAAVPlayerContentPlayhead : NSObject, IIMAContentPlayhead, INativeObject, IDisposable
    {
        [CompilerGenerated]
        [Export("initWithAVPlayer:")]
        public IMAAVPlayerContentPlayhead(AVPlayer player);
        [CompilerGenerated]
        [EditorBrowsable(EditorBrowsableState.Advanced)]
        protected IMAAVPlayerContentPlayhead(NSObjectFlag t);
        [CompilerGenerated]
        [EditorBrowsable(EditorBrowsableState.Advanced)]
        protected internal IMAAVPlayerContentPlayhead(IntPtr handle);

        public override IntPtr ClassHandle { get; }
        [CompilerGenerated]
        public virtual double CurrentTime { get; }
        [CompilerGenerated]
        public virtual AVPlayer Player { get; }
    }

But different from the definition in the Apidefinition.cs file which is the correct definition. IMAAVPlayerContentPlayhead should integrate the abstract class IMAContentPlayhead instead of inheriting the interface of IIMAContentPlayhead.

Perhaps you use the wrong Apidefinition file in the framework folder when you created the nuget. Please update this nuget and release new version.

Best,
Wenfeng
@Wenfengcheng Wenfengcheng linked a pull request Nov 13, 2018 that will close this issue
Open
@Wenfengcheng
Copy link
Author

@tuyen-vuduc

I am very sorry that you can't reply to my issue and #2 , I have forked and modified your repo, and re-released a nuget. Maybe we can maintain the entire project together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade to 3.7.2 and update api definitions Wenfengcheng/googleima-ios-binding
1 participant
@Wenfengcheng