Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Clean up Exploration types & Veda Types for Dataset Layers #1363

Open
sandrahoang686 opened this issue Jan 8, 2025 · 0 comments
Labels
tech debt veda v2 VEDA Refactor Epic Work

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Jan 8, 2025

Context:
Related to comment from PR here => #1361 (comment)

We need to review the data types between the /exploration/types.d.ts file and the /types/veda.ts file. There is duplication happening. We should also check the files that references these types. For example there is typecasting happening which looks to be masking an issues of how we may be defining these types or some mis-transformations/reconciling along the way like here =>

const layer = layers?.find(
(l) => l.id === layerId
) as EADatasetDataLayer | null;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

No branches or pull requests

2 participants