Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Scrollytellingblock MDX component for template instance #1324

Open
1 task
sandrahoang686 opened this issue Dec 15, 2024 · 0 comments
Open
1 task

Expose Scrollytellingblock MDX component for template instance #1324

sandrahoang686 opened this issue Dec 15, 2024 · 0 comments
Assignees
@sandrahoang686
Labels
veda v2 VEDA Refactor Epic Work

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Dec 15, 2024 •
edited
Loading

Currently Adding more story content is breaking in this PR developmentseed/next-veda-ui#22.

We need to expose the MDX components that haven't been exposed yet which the stories mdx depends on like Scrollytellingblock and Chapter. Chapter is exposed but we need to hook it up, Scrolltellingblock still has veda virtual module dependencies which we should decouple from and then expose.

AC:
@sandrahoang686 sandrahoang686 added the veda v2 VEDA Refactor Epic Work label Dec 15, 2024
This was referenced Jan 7, 2025
Open
Open
@hanbyul-here hanbyul-here mentioned this issue Jan 7, 2025
Merged
sandrahoang686 added a commit that referenced this issue Jan 8, 2025
@sandrahoang686
Fix prop type for Map and Scrollytelling (#1361)
93ae948 
**Related Ticket:** #1324 

### Description of Changes
While contemplating on what @sandrahoang686 mentioned about the data
proptype, I realized that our types are wrong for Map and Scrollytelling
(And We have different types, but named same of `DatasetData` which we
should address soon.)

### Notes & Questions About Changes
Map and Scrollytellinglblock seems to expect the same shape of the
dataset which is an object (`VedaData<DatasetData>` - am I missing
anything?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandrahoang686 sandrahoang686

Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sandrahoang686