-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata lookup by timestamp to tmdb3tv.py #700
Comments
This change adds support for the following syntax options: tmdb3tv.py -N <title> <date time> tmdb3tv.py -N <inetref> <date time> For example: tmdb3tv.py -N "The Blacklist" "2021-01-29 19:00:00" <?xml version='1.0' encoding='UTF-8'?> <metadata> <item> <title>The Blacklist</title> <subtitle>Elizabeth Keen</subtitle> <description>As Red and the task force search for Liz, she sets a new plan in motion that has catastrophic consequences.</description> <season>8</season> <episode>4</episode> <inetref>46952</inetref> <collectionref>46952</collectionref> <language>en</language> <releasedate>2021-01-29</releasedate> ... </item> </metadata> In the above example, by specifying the start of the recording time, we were able to acquire the Season, Episode, Subtitle, and Description. Without this new capability, we would have only the Title and a generic description of the TV series. Please note that the TMDB database only stores the date of the initial airing, so the match will not be as precise as in the TvMaze lookup, which stores the date, time, and timezone. If there are multiple episodes aired on a single date, then TMDB provides no way to descriminate between them. It will generate a list with all the episodes matching that date. Resolves: MythTV#700
Special care should be taken when episodes air at or after midnight. To ensure that the episode airdates on TMDB3 are in line with the dates used by TV guides and listings worldwide, episodes that start airing at or after midnight but before 5:00am should be considered part of the previous day. This adjustment allows us to retrieve the correct Season, Episode, Subtitle, and Description during a tmdb3tv.py 'lookup by timestamp'. After this commit, if a user records "Late Night With Seth Meyers" in the Eastern timezone in the United States, it will return the metadata for the 2023-01-25 episode. The timestamp specifies 2023-01-26, but the correct metadata has releasedate = 2023-01-25. tmdb3tv.py -l en -a US -N "Late Night With Seth Meyers" "2023-01-26 00:37:00" <?xml version='1.0' encoding='UTF-8'?> <metadata> <item> <title>Late Night with Seth Meyers</title> <subtitle>Colin Quinn, Gabrielle Union</subtitle> <description>Colin Quinn, Gabrielle Union</description> <season>10</season> <episode>53</episode> <inetref>61818</inetref> <collectionref>61818</collectionref> <language>en</language> <releasedate>2023-01-25</releasedate> ... </item> </metadata> Resolves: MythTV#700
The discussion on PR #702 led to the following open questions
Note: |
FWIW, at least one guide provider defines all times/dates they provide to be in UTC in their metadata APIs, and provides both an origAirDate (date of the original TV airing), and a releaseDate (for TV shows that would typically be the same as origAirDate, but for theatrical movies, it may be different (the date of a movie release is separately provided by that guide provider)). If one is using the appropriate xmltv grabber the (guide providers) originalAirDate, if available, is inserted into the DB for the program. I do not know if that guide providers dates are highly aligned with other sources of date and metadata such as themoviedb. |
@garybuhrmaster |
In the United States, there seems to be a convention for late night programs starting at midnight, or shortly after, of assigning the previous day to air_date. I tested this with "Late Night with Seth Meyers", which starts at 00:35:00 EST, and the TvMaze, TMDB3, and TTVDB4 databases all specify last night's episode as airing on 2023-02-02, even though, technically, it aired on 2023-02-03 in the Eastern timezone (America/New_York). It's the same for other late night talk shows originated from the US. I've tried looking for shows in other countries which either follow or break this convention, but it's been a difficult search. We want to look for countries with more than one timezone, where the crossover of midnight would cause differences in the date part of the timestamp for different timezones. According to I checked TV listings in Australia and Canada, but found both of them primarily show late night talk shows from the US. I didn't find locally generated programs which would clarify behavior. There are very few TV shows whose episodes originate at midnight. There are some local news shows, but they didn't seem to have metadata to distinguish daily episodes. I lack the linguistic skills to find good TV listings for most of the other countries in the list. |
Unless you have a confirmation from themoviedb.org, that they will stick always to that convention, the provided change is useless and subject for further errors. |
Is your feature request related to a problem? Please describe.
When using "TheMovieDB.org V3 television" as the Television Metadata Source, and recording from a Manual Record rule or an automatic record rule based off of OTA broadcast information which does not specify a Subtitle field for TV shows, specific metadata for a TV episode is not available.
Describe the solution you'd like
In the tvmaze.py metadata script, there is an option to find a specific TV episode by providing the name of the show, and a timestamp for the initial airing. When recording the initial airing of a TV episode, use of this option allows us to retrieve specific episode metadata information, such as Season, Episode, Subtitle, and Description.
The same capability should be added to the TMDB metadata retrieval script for TV shows. Users who have chosen to use "TheMovieDB.org V3 television" will be able to collect more complete metadata information for first broadcast recordings.
Describe alternatives you've considered
The only alternative is for the user to select TvMaze instead of TMDB for TV show metadata collection.
The text was updated successfully, but these errors were encountered: