From 8c1b92374c96e01b911d17bc96994d95366994b4 Mon Sep 17 00:00:00 2001 From: "Derek Ostrander (derko)" Date: Sat, 19 Feb 2022 21:10:39 -0500 Subject: [PATCH] Fix how the test host app is made into a .app (#529) In the previous was we would `rstrip` the test_host's app extension. If this happened to be the same as the end of the app name it would strip that too. For example if it was `Foo-App.app` it would change to `Foo-A.app`. This updates to take whatever is before the app extension by splitting the test_host's extension + '.' and taking the first entry. Signed-off-by: dostrander --- bptestrunner/bluepill_batch_test.bzl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bptestrunner/bluepill_batch_test.bzl b/bptestrunner/bluepill_batch_test.bzl index 7210d1c2..36203270 100644 --- a/bptestrunner/bluepill_batch_test.bzl +++ b/bptestrunner/bluepill_batch_test.bzl @@ -29,9 +29,9 @@ def _bluepill_batch_test_impl(ctx): #test_plan test_plan = struct( - test_host = test_host.basename.rstrip( + test_host = test_host.basename.split( "." + test_host.extension, - ) + ".app", + )[0] + ".app", environment = test_env, arguments = test_env, test_bundle_path = bundle_info.bundle_name + bundle_info.bundle_extension,