Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When filtering by popular networks if your balance on the selected network is 0, the displayed fiat balance is incorrect. #12947

Open
cortisiko opened this issue Jan 10, 2025 · 1 comment
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-wallet-ux type-bug Something isn't working

Comments

@cortisiko
Copy link
Member

Describe the bug

This bug was confusing as an end user. I have a wallet with token balances on most popular networks. When I select PALM (a popular network) as my selected network and filter by popular networks, the account bottom sheet correctly shows a token balance of 0 but displays an incorrect fiat balance.

It’s confusing to see a fiat balance when I don’t have any tokens. This creates the impression that the app is broken, as users might think they have funds but fail to display the corresponding token balance.

Expected behavior

If my selected network is a popular network but I do not have any tokens on that network, If i were to filter by popular networks and open the account bottom sheet, the token count and fiat balance should not show any fiat values.

Screenshots/Recordings

Image

Steps to reproduce

Import a wallet with assets across multiple popular networks
Make sure you set one of the popular networks where you do not have any balances as the selected network
Filter by Popular networks
Open the account bottom sheet
Notice the account balance

Error messages or log output

Detection stage

During release testing

Version

7.38.0 (1523)

Build type

None

Device

iPhone 16 Pro

Operating system

iOS

Additional context

No response

Severity

No response

@cortisiko cortisiko added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working labels Jan 10, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 10, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 10, 2025
@MetaMask MetaMask deleted a comment Jan 10, 2025
@MetaMask MetaMask deleted a comment Jan 10, 2025
@alfeng6
Copy link

alfeng6 commented Jan 24, 2025

This is something we should consider when augmenting the account experience @hesterbruikman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-wallet-ux type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants