Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tau_psy.f90 added to build #6

Open
hiker opened this issue Dec 10, 2024 · 2 comments
Open

tau_psy.f90 added to build #6

hiker opened this issue Dec 10, 2024 · 2 comments
Assignees

Comments

@hiker
Copy link
Collaborator

hiker commented Dec 10, 2024

I am surprised that we don't see this problem on NCI. When I install lfric-baf, it copies the tau_psy.f90 files into the infrastructure files, which means this file will be compiled (which then results in linking errors).

  1. Any idea why we don't see this on NCI? I need to manually remove this file from infrastructure/soure/psydata.
  2. Depending on the answer for 1. above, it might be better to move this file out of the infrastructure/source tree, add it to infrastructure/build/psyclone (which doesn't exist here yet, but it is in LFRic core). And then if requested (i.e. tau selected), then grab that file?

The latter approach would also make it easier to support different profiling libs (e.g. Vernier), where atm I am manually copying the psyclone wrapper file into the sources. We could all there wrapper to the psyclone directories, and let fab copy the right file.

@hiker
Copy link
Collaborator Author

hiker commented Dec 10, 2024

I just realised that on NCI atm we don't trigger any profiling. So no psy_data calls are added to the code, so the fab dependency analysis will never include this file to be compiled.

Still, it would be a better solution if baf grabs up the wrapper files explicitly (depending on command line options).

@hiker hiker assigned hiker and unassigned jasonjunweilyu Dec 10, 2024
@hiker
Copy link
Collaborator Author

hiker commented Dec 10, 2024

Fixed in e5e82de (part of vernier branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants