Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import the code from the initial social linker to tag links #4

Open
MaximRouiller opened this issue Dec 3, 2019 · 6 comments
Open
Labels
good first issue Good for newcomers

Comments

@MaximRouiller
Copy link
Owner

Look at the initial module in the social-linker

We will initially copy/paste the code until we are ready to set it as a package.

@MaximRouiller MaximRouiller added this to the Minimum Viable Product milestone Dec 3, 2019
@MaximRouiller MaximRouiller added the good first issue Good for newcomers label Dec 3, 2019
@born-2learn
Copy link

born-2learn commented Dec 4, 2019

@MaximRouiller
I'm interested to work on this.
Once the copy/paste of tracking.js is complete, may i know the other dependencies to be imported or things to be coded.

also, is there a documentation for social-linker repo

@salmanmkc
Copy link
Contributor

not sure if I did it in one of the issues I made here, could be wrong #12

@MaximRouiller
Copy link
Owner Author

Hey @born-2learn, there is no documentation for the original social linker.

That's the sad part of the story. @salmanmkc may have done a PR on the file. Let me merge all the PR and see if we can restructure the code.

I would love tracking.js to be a separate module of the application as it will be invoked from more than one command in the veyr near future.

@born-2learn
Copy link

Hey @MaximRouiller , I would love to work on this. Will be needing some guidance as I'm not very well-versed with TypeScript.

@salmanmkc
Copy link
Contributor

@MaximRouiller I'll start building modularity once I get these functions working

@deshmukhprasad
Copy link

@MaximRouiller is this repo. still active? I would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants