-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ANY capacity value, while still ensuring RESUME is always lower than PAUSE #177
Comments
In what version are these new ACC functions? |
v2021.7.28 (202107280) and newer
All the information is in README.md. |
If The two-unit format is a bit complicated, both for our program and for the user. Can this solution be optimized any further? |
No. Quoting myself...
The logic applied depends on the value given. Here's a practical example: |
When |
I totally missed your point. |
I just learned that the formula I was using was incorrect. The power-voltage is not a linear relationship. And there is no universal formula for devices. So to avoid abnormal usage, we need to make sure the units are same.
Or we don't open this feature to normal users and restrict it to advanced users. For example, provide a tougle for advanced features. In advanced mode, no restrictions are on the user input. Otherwise `resume=3200` and `pause=80` may be incorrectly considered invalid. They are valid, but do not meet the `resume<pause` in the simple way.
|
An advanced user mode is a great idea. |
Personally, I do not understand the battery and must confuse the value. It is best to limit 2 modes: only percent OR millivolts. Ideas? Where are you going to use your advanced mode? It is not comfortable. |
I implemented a new acc feature that lets one use millivolts as opposed to capacity/level thresholds.
The new algorithm kicks in only when the given value is >= 3000 (mV).
This is useful especially for devices that don't provide reliable capacity measurements (I've got one).
It's also another alternative to voltage limit - which works only on very few/special devices.
One can have some capacity thresholds be in millivolts and others in %, simultaneously.
This means, acc 4200 20 works just as well as acc 80 75.
By the way, all capacity thresholds, including shutdown_capacity can be in millivolts.
The text was updated successfully, but these errors were encountered: