Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest timely and differential #31021

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Update to latest timely and differential #31021

merged 2 commits into from
Jan 13, 2025

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Jan 13, 2025 •
edited
Loading

As the title says, update to latest Timely and Differential.

The main changes in this release are a new merge batcher in differential, and updated logging infrastructure in timely.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@antiguru antiguru requested review from aljoscha, jkosh44 and a team as code owners January 13, 2025 13:55
ParkMyCar
ParkMyCar approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapter and Cargo related changes LGTM

teskje
teskje approved these changes Jan 13, 2025
View reviewed changes
src/compute/src/logging.rs Show resolved Hide resolved
src/compute/src/render/top_k.rs Show resolved Hide resolved
@antiguru
Update to latest timely and differential
ee23dfc 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
Feedback
fd6ecc5 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
Copy link
Member Author

Thanks for the reviews!

@antiguru antiguru enabled auto-merge (squash) January 13, 2025 19:15
@antiguru antiguru merged commit 26688f1 into MaterializeInc:main Jan 13, 2025
80 checks passed
@antiguru antiguru deleted the update_td_dd branch January 14, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teskje teskje teskje approved these changes

@ParkMyCar ParkMyCar ParkMyCar approved these changes

@aljoscha aljoscha Awaiting requested review from aljoscha aljoscha is a code owner

@jkosh44 jkosh44 Awaiting requested review from jkosh44 jkosh44 is a code owner

@frankmcsherry frankmcsherry Awaiting requested review from frankmcsherry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antiguru @ParkMyCar @teskje