*: Pare down usage of buf
linting
#30339
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pares down our usage of the
buf
protobuf linting tool by marking most of the files as ignored. There are relatively few files we actually need to maintain backward compatibility for, most are used for communication betweenenvironmentd
andclusterd
which are guaranteed to be running the same version of Materialize.Concretely, this changes
bin/lint
to require protobuf files to be marked withbuf breaking: (ignore | check)
and updates all of the files not currently marked.Motivation
buf
linting has tripped us up before by requiring backwards compatibility where it's not needed. See this Slack thread.Tips for reviewer
What really needs review here are that the protobuf files are correctly marked
ignore
orcheck
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.