[DNM] persist: implement Blob using Postgres and hook it up to sqllogictest #17382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyblue
approved these changes
Jan 27, 2023
| pub async fn open(config: PostgresBlobConfig) -> Result<Self, ExternalError> { | ||
| let pg_config: tokio_postgres::Config = config.url.parse()?; | ||
| let tls = make_tls(&pg_config)?; | ||
| let (mut client, conn) = tokio_postgres::connect(&config.url, tls) |
There was a problem hiding this comment.
This would certainly need to be able to reconnect, so should either the actual connection and checking in the Blob impl functions, or else use deadpool or something.
There was a problem hiding this comment.
yeah, I kinda felt like maybe it should share the pool with PostgresConsensus or something? didn't want to deal thinking through the tradeoffs for a demo, so just did the obvious thing
|
Cleaning up old PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our test invocation my runtime goes from 0m16.084s -> 0m9.849s
Motivation
Tips for reviewer
Checklist
This PR has adequate test coverage / QA involvement has been duly considered.
This PR evolves an existing
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.If this PR will require changes to cloud orchestration, there is a
companion cloud PR to account for those changes that is tagged with
the release-blocker label (example).
This PR includes the following user-facing behavior changes: