From 2aac9769770cdd37fd1715442bb68d12fbeaabee Mon Sep 17 00:00:00 2001 From: Jan Teske Date: Fri, 17 Nov 2023 10:20:10 -0500 Subject: [PATCH] adapter: upgrade parameter sync logging to INFO This allows us to discover which configs were active on a given environment at a given time when debugging a past incident. The volume of these log lines should be pretty low given that we don't update LD flags all the time. --- src/adapter/src/catalog/open.rs | 4 ++-- src/adapter/src/config/backend.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/adapter/src/catalog/open.rs b/src/adapter/src/catalog/open.rs index bd3bba8b9fc2e..8508698fab237 100644 --- a/src/adapter/src/catalog/open.rs +++ b/src/adapter/src/catalog/open.rs @@ -1155,13 +1155,13 @@ impl Catalog { .map(|param| { let name = param.name; let value = param.value; - tracing::debug!(name, value, "sync parameter"); + tracing::info!(name, value, initial = true, "sync parameter"); (name, OwnedVarInput::Flat(value)) }) .chain(std::iter::once({ let name = CONFIG_HAS_SYNCED_ONCE.name().to_string(); let value = true.to_string(); - tracing::debug!(name, value, "sync parameter"); + tracing::info!(name, value, initial = true, "sync parameter"); (name, OwnedVarInput::Flat(value)) })) .collect::>(); diff --git a/src/adapter/src/config/backend.rs b/src/adapter/src/config/backend.rs index 5935b99c32540..2fa4b395cce1c 100644 --- a/src/adapter/src/config/backend.rs +++ b/src/adapter/src/config/backend.rs @@ -10,7 +10,7 @@ use std::collections::BTreeMap; use mz_sql::session::user::SYSTEM_USER; -use tracing::{debug, error}; +use tracing::{error, info}; use crate::config::SynchronizedParameters; use crate::{AdapterError, Client, SessionClient}; @@ -40,7 +40,7 @@ impl SystemParameterBackend { vars.insert(param.name.clone(), param.value.clone()); match self.session_client.set_system_vars(vars).await { Ok(()) => { - debug!(name = param.name, value = param.value, "sync parameter"); + info!(name = param.name, value = param.value, "sync parameter"); } Err(error) => { error!(