Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme download section seems to be out-of-date or incorrect #91

Open
malcolmsailor opened this issue Sep 4, 2023 · 1 comment
Open

Comments

@malcolmsailor
Copy link
Contributor

The readme says:

For downloading a local copy of remote files, see Code.updates_and_checks.remote_scores and the argument convert_and_write_local.

However, there is no function called remote_scores in Code/updates_and_checks.py. There is such a function in Code/collect_convert.py but it appears to be a different function and doesn't have a convert_and_write_local argument. There is a convert_and_write_local function in this second file as well, but there doesn't seem to be an argument by this name anywhere in the code base.

@MarkGotham
Copy link
Owner

Thanks for catching that. What do you think best for handling this? Perhaps a shared download_from_URL function for 3 different use cases:

  1. test suite: no further action (if the URL works then that's information enough)
  2. write a local copy in original format (.krn, .mscx etc.)
  3. convert to mxl and write a copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants