Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUs with ShowInPedia == false are still showing up in the Civilopedia under the Civ's entry #11533

Open
RecursiveVision opened this issue Jan 14, 2025 · 6 comments
Labels
User Interface For UI issues in VP Luas (tooltips, pop-ups etc.) - Does not include base EUI bugs or texturebugs

Comments

@RecursiveVision
Copy link
Collaborator

image

@nobubblegums nobubblegums added the User Interface For UI issues in VP Luas (tooltips, pop-ups etc.) - Does not include base EUI bugs or texturebugs label Jan 14, 2025
@Hokath
Copy link
Contributor

Hokath commented Jan 16, 2025

Report on the forums that dummy buildings are showing in the civilopedia
haven't confirmed yet but sounds related

https://forums.civfanatics.com/threads/semper-fidelis-ideologies-expansion-pack.693449/post-16743498

@skodkim
Copy link

skodkim commented Jan 16, 2025

Actually the building list seems to be full of these. Can be tested with the mod setup + save from #11544

Image

@Hokath
Copy link
Contributor

Hokath commented Jan 16, 2025

Yes, they are dummy buildings from your mod mods that are usually hidden

@azum4roll
Copy link
Collaborator

azum4roll commented Jan 17, 2025

ShowInPedia was probably changed from BOOLEAN to boolean. I'll do a quick sweep and also add a ShowInPedia check on the Civ page.

EDIT: No it's not that. This is the full SQL for buildings not having a tech prereq:

SELECT Buildings.ID, Buildings.Description, Buildings.PortraitIndex, Buildings.IconAtlas FROM Buildings
INNER JOIN BuildingClasses ON Buildings.BuildingClass = BuildingClasses.Type
WHERE Buildings.PrereqTech IS NULL
AND (Buildings.FaithCost = 0 or Buildings.Cost >= 0)
AND Buildings.ShowInPedia = 1
AND Buildings.IsCorporation = 0 AND BuildingClasses.MaxGlobalInstances < 0
AND (BuildingClasses.MaxPlayerInstances <> 1 or Buildings.SpecialistCount > 0)
AND BuildingClasses.MaxTeamInstances < 0;

If ShowInPedia is false they really shouldn't be showing up.

@azum4roll
Copy link
Collaborator

I recall some other criteria being used before ShowInPedia was introduced? What was it again?

@Hokath
Copy link
Contributor

Hokath commented Jan 17, 2025

Hmmm... it was the number of great work slots being -1 or something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface For UI issues in VP Luas (tooltips, pop-ups etc.) - Does not include base EUI bugs or texturebugs
Projects
None yet
Development

No branches or pull requests

5 participants