Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert start cmd Dockerfile #1563

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

CrazyWolf13
Copy link
Collaborator

@CrazyWolf13 CrazyWolf13 commented May 1, 2024

CrazyWolf13 Quick CrazyWolf13 /master → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

Revert #1543

Overview

Temporarly revert the start cmd of the docker container to build-and-start so changes to files for example userstyles don't reqire manual rebuild:

Issue Number (if applicable) #1559

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • Bumps version, if new feature added

@CrazyWolf13 CrazyWolf13 requested a review from Lissy93 as a code owner May 1, 2024 09:35
Copy link

netlify bot commented May 1, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 2f86b16
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/66320cfc6dfacf00084509ee
😎 Deploy Preview https://deploy-preview-1563--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CrazyWolf13 CrazyWolf13 merged commit a7c15ce into Lissy93:master May 1, 2024
7 checks passed
@andres7293
Copy link

andres7293 commented Dec 30, 2024

Hello.

Is there any reason to revert to build-and-start instead of just start?

I have a tiny vps and it got stuck at building step. I am genuinely curious I do not have much knowledge about the project.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants