Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.0 published on npm, but git repo shows v1.5.0 last year #91

Open
stahlmanDesign opened this issue Sep 5, 2019 · 2 comments
Open

Comments

@stahlmanDesign
Copy link

This is the first time I've ever seen a new npm version without the changes being reflected in the git repo. Does the npm url link to the wrong git repo? I want to review the changelog before updating.

npm (v1.6.0 updated 4 sept 2019):
https://www.npmjs.com/package/react-visjs-timeline

Git repo (v1.5.0 updated "last year"):
https://github.com/Lighthouse-io/react-visjs-timeline

@ackwell
Copy link

ackwell commented Sep 13, 2019

Looks like it's an update from depending on vis, to depending on vis-timeline - to coincide with the main vis package's EOL.

diff of the built index file from npm:

$ diff -u 1.5/node_modules/react-visjs-timeline/build/index.js 1.6/node_modules/react-visjs-timeline/build/index.js
--- 1.5/node_modules/react-visjs-timeline/build/index.js	2019-07-26 10:46:55.000000000 +1000
+++ 1.6/node_modules/react-visjs-timeline/build/index.js	2019-09-13 17:37:04.000000000 +1000
@@ -6,11 +6,11 @@

 var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();

-var _visTimelineGraph2d = require('vis/dist/vis-timeline-graph2d.min');
+require('vis-timeline/dist/vis-timeline-graph2d.min.css');

-var _visTimelineGraph2d2 = _interopRequireDefault(_visTimelineGraph2d);
+var _visTimelineGraph2d = require('vis-timeline/dist/vis-timeline-graph2d.min');

-require('vis/dist/vis-timeline-graph2d.min.css');
+var _visTimelineGraph2d2 = _interopRequireDefault(_visTimelineGraph2d);

 var _react = require('react');

which coincides with the new peer dependency warning for vis-timeline.

I'm going to guess the build was uploaded from the branch for PR #90 - not sure why it wasn't merged yet.

@stahlmanDesign
Copy link
Author

stahlmanDesign commented Sep 23, 2019

I decided to upgrade to v1.6.0 and it shows and error:

./node_modules/react-visjs-timeline/build/index.js Module not found: Can't resolve 'vis-timeline/dist/vis-timeline-graph2d.min' in…

It's not clear what else needs to be updated or if vis-timeline should now be a peer dependency or something.
EDIT, I just read your message that vis-timeline needs to be a peer dependency. I added vis-timeline to my package.json and removed vis. It works. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants