Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing event handlers #58

Open
baloola opened this issue Nov 6, 2018 · 0 comments
Open

Missing event handlers #58

baloola opened this issue Nov 6, 2018 · 0 comments

Comments

@baloola
Copy link

baloola commented Nov 6, 2018

Overview

I have noticed that the mouseDown / mouseUp events are missing from the events props, I needed to use them in order to drag specific items.

I noticed it's a bit tricky to use it along with other events, but I think it still might be needed.

I will create a PR in case it is OK to add them :)

Package versions

react-visjs-timeline: 1.5.0
vis version:

Steps to reproduce

Code Snippet

const events = [
  'currentTimeTick',
  'click',
  'contextmenu',
  'doubleClick',
  'groupDragged',
  'changed',
  'rangechange',
  'rangechanged',
  'select',
  'timechange',
  'timechanged',
  'mouseOver',
  'mouseMove',
  'itemover',
  'itemout',
]

Related issues

PR #36 added some missing events ( but not these two )

Screenshots (if appropriate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant