Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate repo? #8

Open
Lewiscowles1986 opened this issue Jan 20, 2017 · 3 comments
Open

Separate repo? #8

Lewiscowles1986 opened this issue Jan 20, 2017 · 3 comments

Comments

@Lewiscowles1986
Copy link
Owner

Should this be moved to a separate org (I'm thinking moving to my business org)?

@dmhendricks
Copy link
Contributor

Feedback:

  1. You might also consider a more Composer-friendly slug, since more and more people are using Composer to manage WordPress. Something like "codesign2/wp-enable-svg" or "codesign2/enable-svg-uploads" whatever (neither of those appear to be currently in use on the wp.org repo, either).
  2. I would make the slug match the plugin directory name.
  3. It seems that most WP plugins put the files in the Git root rather than wp-content/plugins/plugin-slug. I think (?) this is also required in order to properly work with GitHub Updater, yes?

@Lewiscowles1986
Copy link
Owner Author

Lewiscowles1986 commented Nov 15, 2017

I've never used the github updater, but I'd appreciate PR's (preferably with issues) against each individual point here. Even just issues raised so I can gauge user-input before PR'ing or accepting PR's then I'd be grateful.

@dmhendricks
Copy link
Contributor

(also, though it will have no impact on function, it's not typical in WP to name the main plugin file index.php. Generally, they are named something like my-plugin-name/my-plugin-name.php or enable-svg-uploads/enable-svg.php, purely as examples.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants