From 7e8ea3a3118115736cbfcc1a54b525ab70c04305 Mon Sep 17 00:00:00 2001 From: Alexis Grojean Date: Mon, 27 Nov 2023 12:35:33 +0100 Subject: [PATCH] Use v1 of reusable workflows in CI as the work branch for rust support has been merged. --- .../workflows/build_and_functional_tests.yml | 2 +- .github/workflows/coding_style_checks.yml | 26 ++++++++----------- .github/workflows/guidelines_enforcer.yml | 2 +- 3 files changed, 13 insertions(+), 17 deletions(-) diff --git a/.github/workflows/build_and_functional_tests.yml b/.github/workflows/build_and_functional_tests.yml index 7c797e0..3f5937d 100644 --- a/.github/workflows/build_and_functional_tests.yml +++ b/.github/workflows/build_and_functional_tests.yml @@ -20,7 +20,7 @@ on: jobs: build_application: name: Build application using the reusable workflow - uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@rust-build-artifacts + uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1 with: upload_app_binaries_artifact: "compiled_app_binaries" builder: ledger-app-builder diff --git a/.github/workflows/coding_style_checks.yml b/.github/workflows/coding_style_checks.yml index 8d1b488..8b60395 100644 --- a/.github/workflows/coding_style_checks.yml +++ b/.github/workflows/coding_style_checks.yml @@ -1,5 +1,9 @@ name: Run coding style check +# This workflow will run linting checks to ensure a level of code quality among all Ledger applications. +# +# The presence of this workflow is mandatory as a minimal level of linting is required. + on: workflow_dispatch: push: @@ -8,19 +12,11 @@ on: - main - develop pull_request: - + jobs: - format: - name: Check code formatting - runs-on: ubuntu-latest - container: - image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder:latest - steps: - - name: Clone - uses: actions/checkout@v2 - - name: Run cargo fmt - uses: actions-rs/cargo@v1 - with: - command: fmt - args: --all -- --check - \ No newline at end of file + check_linting: + name: Check linting using the reusable workflow + uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_lint.yml@v1 + with: + source: './src' + extensions: 'rs' diff --git a/.github/workflows/guidelines_enforcer.yml b/.github/workflows/guidelines_enforcer.yml index ddb72e3..fdaf9f2 100644 --- a/.github/workflows/guidelines_enforcer.yml +++ b/.github/workflows/guidelines_enforcer.yml @@ -20,4 +20,4 @@ on: jobs: guidelines_enforcer: name: Call Ledger guidelines_enforcer - uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_guidelines_enforcer.yml@rust-build-artifacts + uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_guidelines_enforcer.yml@v1