Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move primal::NumericArray to core? #1488

Open
gunney1 opened this issue Jan 13, 2025 · 1 comment
Open

Move primal::NumericArray to core? #1488

gunney1 opened this issue Jan 13, 2025 · 1 comment
Labels
Core Issues related to Axom's 'core' component Primal Issues related to Axom's 'primal component

Comments

@gunney1
Copy link
Contributor

gunney1 commented Jan 13, 2025 •
edited
Loading

This issue is a proposal. Please comment.

primal::NumericArray is a statically-sized array with arithmetic operators defined. It has general utility and no real dependence on primal. It is particularly useful for multidimensional index operations in quest code and for structured mesh operations. While we can #include "axom/primal/geometry/NumericArray.hpp", that suggests a dependency that isn't real. Hence the proposal to move to core. Comments?
@gunney1 gunney1 added Core Issues related to Axom's 'core' component Primal Issues related to Axom's 'primal component labels Jan 13, 2025
@rhornung67
Copy link
Member

IMO, things like that that are generally useful and not dependent on a particular Axom component, should be moved to "core". Things like this grew up organizally. It's good to revisit and make changes for the overall health of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Issues related to Axom's 'core' component Primal Issues related to Axom's 'primal component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhornung67 @gunney1