From 868ee2c596777cb6f652958a1569787cca0da575 Mon Sep 17 00:00:00 2001 From: Omer Yacine Date: Sun, 6 Oct 2024 15:20:29 +0200 Subject: [PATCH] resolve fixmes --- mm2src/mm2_main/src/rpc/streaming_activations/balance.rs | 1 - mm2src/mm2_main/src/rpc/streaming_activations/mod.rs | 2 +- mm2src/mm2_main/src/rpc/streaming_activations/tx_history.rs | 1 - mm2src/mm2_net/src/event_streaming/sse_handler.rs | 6 +----- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/mm2src/mm2_main/src/rpc/streaming_activations/balance.rs b/mm2src/mm2_main/src/rpc/streaming_activations/balance.rs index 526c4baf5b..fa49f0a8d6 100644 --- a/mm2src/mm2_main/src/rpc/streaming_activations/balance.rs +++ b/mm2src/mm2_main/src/rpc/streaming_activations/balance.rs @@ -80,7 +80,6 @@ pub async fn enable_balance( let streamer = TendermintBalanceEventStreamer::new(coin.clone()); ctx.event_stream_manager.add(client_id, streamer, coin.spawner()).await }, - // FIXME: What about tokens?! _ => Err(BalanceStreamingRequestError::CoinNotSupported)?, }; diff --git a/mm2src/mm2_main/src/rpc/streaming_activations/mod.rs b/mm2src/mm2_main/src/rpc/streaming_activations/mod.rs index 5155b13eb9..c0a9bdf800 100644 --- a/mm2src/mm2_main/src/rpc/streaming_activations/mod.rs +++ b/mm2src/mm2_main/src/rpc/streaming_activations/mod.rs @@ -32,7 +32,7 @@ pub struct EnableStreamingRequest { /// The success/ok response for any event streaming activation request. pub struct EnableStreamingResponse { pub streamer_id: String, - // FIXME: If the the streamer was already running, it is probably running with different configuration. + // TODO: If the the streamer was already running, it is probably running with different configuration. // We might want to inform the client that the configuration they asked for wasn't applied and return // the active configuration instead? // pub config: Json, diff --git a/mm2src/mm2_main/src/rpc/streaming_activations/tx_history.rs b/mm2src/mm2_main/src/rpc/streaming_activations/tx_history.rs index 4b0775fe7e..ac37ca21b5 100644 --- a/mm2src/mm2_main/src/rpc/streaming_activations/tx_history.rs +++ b/mm2src/mm2_main/src/rpc/streaming_activations/tx_history.rs @@ -67,7 +67,6 @@ pub async fn enable_tx_history( let streamer = ZCoinTxHistoryEventStreamer::new(coin.clone()); ctx.event_stream_manager.add(client_id, streamer, coin.spawner()).await }, - // FIXME: What about tokens?! _ => Err(TxHistoryStreamingRequestError::CoinNotSupported)?, }; diff --git a/mm2src/mm2_net/src/event_streaming/sse_handler.rs b/mm2src/mm2_net/src/event_streaming/sse_handler.rs index ec4906d515..84eda03cc1 100644 --- a/mm2src/mm2_net/src/event_streaming/sse_handler.rs +++ b/mm2src/mm2_net/src/event_streaming/sse_handler.rs @@ -30,11 +30,7 @@ pub async fn handle_sse(request: Request, ctx_h: u32) -> Result