Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change default host #1148

Open
antonkomarev opened this issue Jan 15, 2025 · 0 comments
Open

Add ability to change default host #1148

antonkomarev opened this issue Jan 15, 2025 · 0 comments

Comments

@antonkomarev
Copy link

antonkomarev commented Jan 15, 2025

For the testing purposes I need to change https://api.github.com host to the mock API url, but there is no way to do it. All auto-tests should go to the mock service, instead of real GitHub.

We can use enterprise url as a workaround, but it looks like a wrong path.

I see 3 ways to implement this feature:

  1. Check in Github\Client::__construct method if AddHostPlugin already defined, and skip it's definition in this case. Set enterprise URL will require the same check.

  2. Add method to change host plugin manually in Github\Client object.

  3. Make Github\Client::getHttpClientBuilder public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant