Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.0: Save Pull Request data to DB until the MERGED, CLOSED, or STALE #177

Open
thatkookooguy opened this issue Nov 3, 2018 · 1 comment
Open

V2.0: Save Pull Request data to DB until the MERGED, CLOSED, or STALE #177

thatkookooguy opened this issue Nov 3, 2018 · 1 comment
Assignees
@thatkookooguy
Labels
database Everything that is related to managing\writing\reading the DB. feature Everything that needs an implementation and is new Server Related to server side changes
Milestone
achievibit V2.0

Comments

@thatkookooguy
Copy link
Member

thatkookooguy commented Nov 3, 2018 •
edited
Loading

Save Pull Request data to DB for a period

FEATURE

Heroku keeps resetting dynos every now and then and we lose data on PRs that are open for a long time.

We should keep PR data in a table that deletes stale data (PR that haven't been updated for other a month or whatever we agree on :-)), or just finished.

When we get a webhook event from GitHub, we'll fetch the PR data from the database and update it with the new delta

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@thatkookooguy thatkookooguy added feature Everything that needs an implementation and is new database Everything that is related to managing\writing\reading the DB. Server Related to server side changes labels Nov 3, 2018
@thatkookooguy thatkookooguy added this to the achievibit V2.0 milestone Nov 3, 2018
@thatkookooguy
Copy link
Member Author

thatkookooguy commented Apr 29, 2021 •
edited
Loading

  • Implemented STALE deletion of Pull Requests in 36061a8
    Every start of the week, the task will check for pull requests in the database that weren't updated in the past 100 days and delete them.. maybe later, having stale PRs will be an achievement of it's own :-)
  • Currently implementing merge in v2 (or at least a basic merge for now with additional functionalities later),
  • Should also handle closed pull request events in my next pr

thatkookooguy added a commit that referenced this issue Apr 29, 2021
@thatkookooguy
feat(engine): add pr closed handling
cd6aeb0 
for now, it deletes the pr. look at added TODO to see the wanted behavior. but for now, this is good
enough

related to #177
@thatkookooguy thatkookooguy mentioned this issue Apr 29, 2021
Merged
thatkookooguy added a commit that referenced this issue Apr 29, 2021
@thatkookooguy
feat(engine): add pr closed handling
4716037 
for now, it deletes the pr. look at added TODO to see the wanted behavior. but for now, this is good
enough

related to #177
github-actions bot pushed a commit that referenced this issue Apr 29, 2021
@semantic-release-bot
chore(release): 2.0.0-beta.12 [skip ci]
952431e 
# [2.0.0-beta.12](v2.0.0-beta.11...v2.0.0-beta.12) (2021-04-29)

### Features

* **models:** add missing PR fields ([eb31d69](eb31d69))
* **engine:** add pr closed handling ([4716037](4716037)), closes [#177](#177)
github-actions bot pushed a commit that referenced this issue Apr 29, 2021
@semantic-release-bot
chore(release): 2.0.0-beta.12 [skip ci]
27e278c 
# [2.0.0-beta.12](v2.0.0-beta.11...v2.0.0-beta.12) (2021-04-29)

### Features

* **models:** add missing PR fields ([eb31d69](eb31d69))
* **engine:** add pr closed handling ([4716037](4716037)), closes [#177](#177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatkookooguy thatkookooguy

Labels
database Everything that is related to managing\writing\reading the DB. feature Everything that needs an implementation and is new Server Related to server side changes
Projects
None yet
Milestone
achievibit V2.0
Development

No branches or pull requests
2 participants
@thatkookooguy @dunaevsky