From 5a5f294f54397476b512236e4e185574ae7238a8 Mon Sep 17 00:00:00 2001 From: Jeremy Wiebe Date: Fri, 20 Dec 2024 15:15:32 -0800 Subject: [PATCH] Update changesets' auto-commit feature to not suppress CI on commits (#1100) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary: I recently updated our Changesets config to auto-commit the `.md` file when using `yarn changset` to describe a set of changes. This broke our releases as the default behaviour is that Changesets adds `[skip ci]` to the commit created when running `yarn changesets version`. No CI on that PR/commit, meant that none of our release Github Actions ran! So this PR fixes the config so that Changesets no longer adds `[skip ci]` to any commits, but still auto-commits them. ### Similar PRs * Wonder-Blocks: https://github.com/Khan/wonder-blocks/pull/2409 * Wonder-Stuff: https://github.com/Khan/wonder-stuff/pull/1100 (this PR!) * Perseus: https://github.com/Khan/perseus/pull/2052 Issue: "none" ## Test plan: Land this PR Merge `main` into an open Version Packages PR Land that PR and ensure the release goes out Author: jeremywiebe Reviewers: jandrade, somewhatabstract Required Reviewers: Approved By: jandrade Checks: ✅ Test (macos-latest, 20.x), ✅ codecov/project, ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Analyze (javascript), ✅ gerald, ⏭️ dependabot Pull Request URL: https://github.com/Khan/wonder-stuff/pull/1100 --- .changeset/config.json | 4 ++-- .changeset/short-buttons-juggle.md | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 .changeset/short-buttons-juggle.md diff --git a/.changeset/config.json b/.changeset/config.json index 09a5bba7..87e1855a 100644 --- a/.changeset/config.json +++ b/.changeset/config.json @@ -1,7 +1,7 @@ { - "$schema": "https://unpkg.com/@changesets/config@1.7.0/schema.json", + "$schema": "https://unpkg.com/@changesets/config@2/schema.json", "changelog": "@changesets/cli/changelog", - "commit": true, + "commit": ["@changesets/cli/commit", { "skipCI": false }], "linked": [], "access": "public", "baseBranch": "main", diff --git a/.changeset/short-buttons-juggle.md b/.changeset/short-buttons-juggle.md new file mode 100644 index 00000000..a845151c --- /dev/null +++ b/.changeset/short-buttons-juggle.md @@ -0,0 +1,2 @@ +--- +---