Add support for single-file uploads #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very useful thanks @jreyesr I will do some testing and make sure it doesn't break anything but it should be ok. |
|
@Joffcom Is it possible to get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for file fields in forms. See the image below, which has an ordinary Text field and another field which is a file picker:
This causes the following data to be output from the Form trigger. Note that it has both JSON and binary data (though the node works as well with only JSON data, as it is now, or only binary data):
This change would expand the scope of the Form Trigger to also include "file-ingestion" workflows, such as a workflow that prompts the user for a file and then emails it it to multiple people, or also for simulation/manual triggering of workflows that need files (such as a workflow that would normally be triggered by Gmail's On Message Received with attachments).
Currently, it's not possible to receive files, even by overriding the HTML+JS of the form, so any such workflows aren't possible (I think, I haven't actually tried, but the code doesn't seem to support file parsing)
This PR closes #1