Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struggling to install zhudi #41

Open
lindenr opened this issue Aug 17, 2023 · 7 comments
Open

Struggling to install zhudi #41

lindenr opened this issue Aug 17, 2023 · 7 comments

Comments

@lindenr
Copy link
Contributor

lindenr commented Aug 17, 2023

Hi - this is probably a silly issue on my end, apologies if so. I uninstalled previous zhudi files and ran

pip install git+https://github.com/Jiehong/Zhudi

which looked successful but there doesn't seem to be a zhudi command that I can run now. Running python -m zhudi hangs. Is this expected?

@lindenr
Copy link
Contributor Author

lindenr commented Aug 17, 2023

EDIT - fixed the delay, just had to uninstall some problematic packages. Still not sure why just zhudi doesn't work though.

Ah actually - running python -m zhudi, if I wait for about 30 seconds then the window pops up! Not sure why it takes so long.

@Jiehong
Copy link
Owner

Jiehong commented Aug 24, 2023

Hello.

v1.8 has removed the command so far, and I haven't re-added it yet since I migrated the project to poetry.

I also don't know why it hangs for so long like that. Is that happening each time you start it?

Temporarily, you can install the v1.7 instead, which will give you zhudi back:

pip install git+https://github.com/Jiehong/[email protected]

Note: v1.7 does not come with its own data, so you'll still need your previous data assuming it's still in your home dir.

@lindenr
Copy link
Contributor Author

lindenr commented Oct 31, 2023

Hi! Thanks for the reply. The delay was a problem on my end, that's fixed now. Zhudi now works on my machine.

There are a few minor issues (similar to the ones I submitted PRs for last time), would you accept PRs? E.g. for things like character search only returning exact matches, and some of the menus rendering weirdly. Let me know and I'll open some issues :)

@Jiehong
Copy link
Owner

Jiehong commented Nov 2, 2023

The delay was a problem on my end, that's fixed now. Zhudi now works on my machine.

What did you do to make it work? I'm curious.

There are a few minor issues (similar to the ones I submitted PRs for last time

The latest version is trying to do a few things, and maybe not doing everything very well:

  • package the dictionary by default, so no installation is required;
  • as a consequence, no pre-processing is needed when zhudi is installed on a user's machine;
  • outsource the storage and searching to an external lib, in this case SQLite (this fixes some super weird and long loop the code had);
  • Migrating to GTK4 (this bit is not super well documented, so the menu things might be related).

But the search speed is a bit slow sometimes, but I live with it so far.

@lindenr
Copy link
Contributor Author

lindenr commented Nov 2, 2023

To get rid of the delay I had to uninstall some package, I think it was xdg-desktop-portal-gnome (I'm on arch linux). It was affecting other applications too in the same way, not just zhudi.

To get zhudi to work now I think the only way is to git clone and then run python -m zhudi. I don't think pip installing does anything. This might be worth mentioning in the readme.

@lindenr
Copy link
Contributor Author

lindenr commented Nov 2, 2023

By the way, I'm a big fan of the latest version! I really like the packaging and lack of pre-processing. The search speed also seems fine for me, it's pretty instant for my searches.

@lindenr
Copy link
Contributor Author

lindenr commented Nov 2, 2023

I don't think pip installing does anything
To clarify this - it definitely installs the zhudi package, but that doesn't copy the db files in zhudi-data/ so zhudi fails on startup with an sqlite error. Does pip installing work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants