Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve BuildInputBuilder so it can be used anywhere given a base location #85

Open
fabiobrz opened this issue Sep 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@fabiobrz
Copy link
Member

https://github.com/Intersmash/intersmash/blob/main/tools/intersmash-tools-provisioners/src/main/java/org/jboss/intersmash/tools/application/openshift/input/BuildInputBuilder.java#L76 makes the provisioning tooling depend on Intersmash shared deployments.

Such component should be instead used only at test time, hence it has notjing to do with provisioners, and should be moved/refactored accordingly.

  • Environment: N/A
  • Steps to reproduce: N/A
@fabiobrz fabiobrz mentioned this issue Sep 12, 2023
10 tasks
@fabiobrz fabiobrz moved this to Todo in Intersmash library Sep 18, 2023
@fabiobrz fabiobrz added this to the IM2 - WIP milestone Feb 2, 2024
@fabiobrz fabiobrz added the enhancement New feature or request label Mar 29, 2024
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Sep 19, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Intersmash library Oct 19, 2024
@fabiobrz fabiobrz reopened this Oct 19, 2024
Copy link

dosubot bot commented Jan 20, 2025

Hi, @fabiobrz. I'm Dosu, and I'm helping the intersmash team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The BuildInputBuilder component is improperly dependent on shared deployments.
  • You suggested refactoring or relocating it to limit its use to testing purposes.
  • No comments or further activity have been made on this issue.

Next Steps:

  • Is this issue still relevant to the latest version of the intersmash repository? If so, please comment to keep the discussion open.
  • If there is no further activity, the issue will be automatically closed in 30 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 20, 2025
@fabiobrz fabiobrz moved this from Done to In Progress in Intersmash library Jan 21, 2025
@fabiobrz fabiobrz removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant