Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to set the toRender parameters dynamically #239

Open
1 of 3 tasks
kerthcet opened this issue Jan 16, 2025 · 0 comments
Open
1 of 3 tasks

Able to set the toRender parameters dynamically #239

kerthcet opened this issue Jan 16, 2025 · 0 comments
Labels
needs-kind Indicates a PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Comments

@kerthcet
Copy link
Member

kerthcet commented Jan 16, 2025

What would you like to be added:

Here's an example from Triton_RTLLM with lws, https://github.com/triton-inference-server/tutorials/blob/main/Deployment/Kubernetes/EKS_Multinode_Triton_TRTLLM/multinode_helm_chart/chart/templates/deployment.yaml,
it needs to set a bunch of parameters dynamically, see

          - python3
          - ./server.py
          - leader
          - --triton_model_repo_dir={{ $.Values.triton.triton_model_repo_path }}
          - --namespace={{ $.Release.Namespace }}
          - --pp={{ $.Values.tensorrtLLM.parallelism.pipeline }}
          - --tp={{ $.Values.tensorrtLLM.parallelism.tensor }}
          - --gpu_per_node={{ $.Values.gpuPerNode }}
          - --stateful_set_group_key=$(GROUP_KEY)

We should support this, basically, we can set the params in the model.spec.inferenceFlavors[x].params, with a prefix like Params_GPU_PER_NODE, when rending, we'll cut the Params_.

Why is this needed:

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-kind Indicates a PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants