Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Infisical integrate with Digital Ocean's App Env variables #732

Closed
whoacowboy opened this issue Jul 11, 2023 · 11 comments · Fixed by #779
Closed

Does Infisical integrate with Digital Ocean's App Env variables #732

whoacowboy opened this issue Jul 11, 2023 · 11 comments · Fixed by #779

Comments

@whoacowboy
Copy link

Does Infisical integrate with Digital Ocean's App Environment Variables?

@afrieirham
Copy link
Contributor

I think it's has been discussed here #673

But I don't think anyone's working on it though.

@whoacowboy
Copy link
Author

@afrieirham Thanks for the response. I found out DO doesn't have an API to edit env variables. If it is something you are interested in you can vote and comment here.

@afrieirham
Copy link
Contributor

@afrieirham Thanks for the response. I found out DO doesn't have an API to edit env variables. If it is something you are interested in you can vote and comment here.

Oh wow didn't know that. Thank you for sharing that.

In that case we need to wait for them to make the API available first. Otherwise it would be impossible to do the integrations.

@afrieirham
Copy link
Contributor

Wait I think it's available now here https://docs.digitalocean.com/reference/api/api-reference/#operation/apps_update

Go to specs > services > envs

image

@afrieirham
Copy link
Contributor

afrieirham commented Jul 19, 2023

Tested and verified, it works!

  1. Deploy a project in App Platform and get the id in the url.
  2. Make a request PUT to https://api.digitalocean.com/v2/apps/{id} with body below
{
    "spec": {
        "name": "<YOUR_APP_NAME>",
        "envs": [
            {
                "key": "DB_NAME",
                "value": "infisical"
            }
        ]
    }
}

Also tested, when the old env variable is not included in the array, it will be deleted.

cc @dangtony98 I think this issue can be worked on if anyone's interested.

@dangtony98
Copy link
Collaborator

Oh wow thanks for testing and verifying @afrieirham! — This is excellent news.

I'll add it to the pinned integration issue so we can get some hands on it 😄

@afrieirham
Copy link
Contributor

Working on this.

@dangtony98
Copy link
Collaborator

@whoacowboy This feature has been merged is now live in production 😄

@afrieirham
Copy link
Contributor

cc @fruneen

@fruneen
Copy link

fruneen commented Jul 24, 2023

amazing, thanks a lot 🚀

@whoacowboy
Copy link
Author

Wow, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants