Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd+K Popup #675

Open
7 tasks
vmatsiiako opened this issue Jun 22, 2023 · 13 comments
Open
7 tasks

Cmd+K Popup #675

vmatsiiako opened this issue Jun 22, 2023 · 13 comments
Labels
🚀 feature request New feature or request help wanted Open for contributions from the community ✨ UX

Comments

@vmatsiiako
Copy link
Collaborator

Feature description

When people click cmd+K (or ctrl+K on Windows), they should see such a modal popup:

Screenshot 2023-06-19 at 13 11 32

Here are some ideas for what actions can be included in this modal:

  • Create a new project
  • Add a folder
  • Add a secret
  • Add a new member to a project
  • Invite a user to Infisical
  • etc

In future, if a person is exploring a particular environment, we should have option to

  • Replicate/Inherit an environment

Why would it be useful?

It provides an amazing developer experience, and speeds up many actions.

Additional context

Add any other context about the problem here.

@vmatsiiako vmatsiiako added 🚀 feature request New feature or request help wanted Open for contributions from the community ✨ UX labels Jun 22, 2023
@DJaegerScript
Copy link

is this issue still open? I think I can help to check it out and develop the feature

@vmatsiiako
Copy link
Collaborator Author

@DJaegerScript yes, it is! Please join our Slack if you need any help: https://infisical.com/slack

@MrPoliteGrizlyM
Copy link

Hey @vmatsiiako is this feature still open? lmk if anyone else is working on this one.

@vmatsiiako
Copy link
Collaborator Author

Hey @MrPoliteGrizlyM! I don't think anyone is working on it at the moment! Would be awesome if you could help!

@MrPoliteGrizlyM
Copy link

MrPoliteGrizlyM commented Nov 8, 2023

@vmatsiiako Alright, sounds good! I will get this done by Friday 🚀
I will reply to this thread if anything changes.
Can you elaborate more on this:

In future, if a person is exploring a particular environment, we should have option to
Replicate/Inherit an environment

Examples would be very helpful, thanks!

@vmatsiiako
Copy link
Collaborator Author

An example of that is: imagine you are currently in the explore for a particular environment in a certain project. You could click cmd+K and select "duplicate environment" under a different name

@MrPoliteGrizlyM
Copy link

Gotcha, just want to confirm:
Do you mean by "environment" the dev/test/staging/production/some_custom_env? Lets say you have couple of folders and secrets in dev env. By clicking "Duplicate environment" in dev, all of the content will be copied to the selected env or new created env (modal diolog will be shown to which exactly env this should be copied).

@vmatsiiako
Copy link
Collaborator Author

Yes, indeed!

@MrPoliteGrizlyM
Copy link

MrPoliteGrizlyM commented Nov 10, 2023

Hey @vmatsiiako, thank you for your confirmation about the "duplicate environment" feature, I'm on it! I will implement this right after I finish the basic actions like "Create Secret", "Create Project" etc.
Implementing CMD+K feature takes a bit longer than I expected. Currently I'm exploring how I should compose the action modals, so new action modals can be added much easier. I will let you know the status on Monday!
For now, I recorded a short video on the CMD+K feature UI. Could you please review it and give me feedback? Let me know if any styles/icons needs to changed. Thank you!

CMD+K.Feature.small.mp4

I'm planning to make the exact same UX just like in Linear: Click Action -> Close Window -> Show corresponding action modal (CMD+K window can't be open until this modal is closed). I'm open to discuss this!

@vmatsiiako
Copy link
Collaborator Author

@MrPoliteGrizlyM i just learn from @dangtony98 and @maidul98 that they are working on the revamp to the dashboard which might have a lot of merge conflicts with this issue. @dangtony98 what do you think we should do?

@MrPoliteGrizlyM
Copy link

@vmatsiiako I see, in this case I will wait until you guys finish the dashboard. Thanks for letting me know!
I haven't pushed anything big yet, I've pushed only the CMDK demo. Only the frontend/src/pages/_app.tsx is modified.
@dangtony98 @maidul98 Are you guys planning to use all of the modals as components? I have found that couple of modals are hardcoded in the pages for example "Create a new project" on the org/[id]/overview page. Some of them are in the separate file for example the "Create secret" modal in the "CreateSecreForm" component. It will be very useful if we could reuse all of the modals for the CMDK feature. I was thinking of implementing the "ModalsFactory" myself that will contain all of the modals in the project. Let me know what you think 🙂

@Grraahaam
Copy link
Contributor

Would improve the UX by a lot!

I was also thinking about adding context-awareness, for example if you're on the organization page, it could show you the list of your most recently opened projects to access them quickly.

Same for the project overview and environment pages where you could press CMD+K to switch between environment and also go to a specific secret (e.g. anchor, scroll mechanism).

What do you think?

@Grraahaam
Copy link
Contributor

@vmatsiiako @MrPoliteGrizlyM Any news about this feature? It'd be really useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature request New feature or request help wanted Open for contributions from the community ✨ UX
Projects
None yet
Development

No branches or pull requests

4 participants