Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 6-digit code to an email link during signup #58

Open
vmatsiiako opened this issue Nov 30, 2022 · 9 comments
Open

Change 6-digit code to an email link during signup #58

vmatsiiako opened this issue Nov 30, 2022 · 9 comments
Assignees
Labels
🚀 feature request New feature or request good first issue Good for newcomers help wanted Open for contributions from the community

Comments

@vmatsiiako
Copy link
Collaborator

Feature description

During signup, users get an email with a 6-digit code that they later need to copy and paste into the next signup step. Ideally, we would not to substitute it to an email link that people click and it automatically opens up the next signup step (after verifying that the link is correct).

Why would it be useful?

Links are both more secure and effortless than 6-digit codes. This would be very good to have!

@vmatsiiako vmatsiiako added 🚀 feature request New feature or request good first issue Good for newcomers help wanted Open for contributions from the community labels Nov 30, 2022
@khoa165
Copy link
Contributor

khoa165 commented Jun 19, 2023

@vmatsiiako hi Vlad, I am new to OSS contributing, hoping to pick up my first issue. Do you know if this has been done yet?

@vmatsiiako
Copy link
Collaborator Author

hey @khoa! Excited for you to join our community and hopefully contribute to Infisical. You should also consider joining our Slack for contributors. Here is the link: https://infisical.com/slack

I think this would be a great issue. I'd love to hear what @dangtony98 thinks about it too.

@khoa165
Copy link
Contributor

khoa165 commented Jun 19, 2023

@vmatsiiako do you know how I can setup the email/SMTP? I used to just use my own personal gmail/password and put it in .env file. However, Google recently disabled/deprecated the ability to allow for less secure app access, so I am not sure if there is alternative or if there is shared email account from Infisical for this purpose.

Screenshot 2023-06-19 at 2 16 57 PM

@vmatsiiako
Copy link
Collaborator Author

vmatsiiako commented Jun 19, 2023

I see. @dangtony98 do you have any ideas for how we could get around this?

I think you might be able to sue the free version of sendgrid

@khoa165
Copy link
Contributor

khoa165 commented Jun 19, 2023

@vmatsiiako from what I just dig around, sendgrid seems to offer SMTP server instead of giving you a free email.
Specifically, I think I am looking for maybe alternative of what I should populate these fields in .env with:

SMTP_HOST=Gmail
SMTP_PORT=
SMTP_NAME=
[email protected]
SMTP_PASSWORD=[my email password]

I made sure to put the correct email/password yet it did not send me the email for 6-digit code (step 2 of signup)

@maidul98
Copy link
Collaborator

maidul98 commented Jun 19, 2023

If you want to configure SMTP for local development, you can simply use the mailhog details below to your .env

SMTP_HOST=smtp-server
SMTP_PORT=1025
SMTP_NAME=<whatever you like>
[email protected]
SMTP_PASSWORD=

All mail will then be sent here http://localhost:8025/

@dangtony98
Copy link
Collaborator

dangtony98 commented Jun 19, 2023

@khoa165 You should read the documentation we have for configuring Infisical with various email providers here: https://infisical.com/docs/self-hosting/configuration/email

We support SendGrid, AWS SES, Mailgun, and a number of other confirmed providers if you wish to set up emailing outside of the development mailing server :)

@khoa165
Copy link
Contributor

khoa165 commented Jun 19, 2023

Ahhhh @dangtony98 thanks for the info. I was just trying to do local development and the variables that Maidul provided are working for me.

@Ananmayd
Copy link

@vmatsiiako I would love to work on this issue. Can you assign it to me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature request New feature or request good first issue Good for newcomers help wanted Open for contributions from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants