-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other Vercel Integrations getting overwritten by Infisical #431
Comments
Right, this is a very valid use case! @dangtony98 was looking into this some time ago Thank you for flagging :) |
I've just encountered the same issue. |
Hey @polypixeldev @Makisuo! I've added this to our roadmap as sync prioritization/behavior (will likely get to it in April). The idea is we'll give users the ability to select which type of sync behavior you want such as:
... This is still an early train of thought but we'll have this fleshed-out in the coming month. |
Is this still being worked on? |
I can work on this one @dangtony98 |
hi, is this still being worked on ? |
+1, this is quite frustrating. Other integrations often completely automate the setting of their relevant env vars, overriding them essentially creates a bunch of work to transcribe these values to Infisical by hand and increases the likelihood of misconfiguration. I don't think this fix needs the fine-grained controls discussed above -- as a starting point simply not unsetting env vars that are already set in Vercel and not referenced in Infisical would be significantly preferable to the current behavior of silently nuking them. |
@nealchandra I think the current approach tries to keep Infisical as a single source of truth. This is why it attempts to create a one to one mapping of secrets in Infisical (this can mean deleting ones that do not exist in the thrid party service). It sounds like you would instead like to sync secrets over to the thrid party service by: update them if they exist, create them if they don't exist and leave eveything else as is? @Makisuo Would you also agree with this flow? |
@maidul98 Thanks for the reply. Yep that's right -- while I can see the intent behind trying to make Infisical the single source of truth, in practice I think that is doing more harm than good. In reality I think there are always going to be times where it may be desirable to manually set a var or merge the Infisical settings with external ones (i.e. other integrations). There are simply too many utilities and workflows on platforms like Vercel and not all of them will support easy integration with Infisical. The other reason I'd prefer this approach is because as the user I would still have control to either not use the other integration, manually unset the variables and define them in Infisical, or to allow management of them outside of Infisical. With the current behavior, I have no control at all. |
Hey, yes that sounds like a good solution and would work for me. Later on, imo it would be nice to have the option to choose between overwriting or just writing if they don't exist. But it's not nesscaryl a requirement right now, for me at least. |
This is a big problem that needs to be warned about when adding the integration. It blew up our application. |
I have created a $50 bounty to fix this issue. |
Describe the bug
When Infisical is updated, it deletes all environment variables for a different integration I use (sentry)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Shouldnt overried them
Platform you are having the issue on:
Vercel
The text was updated successfully, but these errors were encountered: