Add integration for GitHub environment secrets #1194
Conversation
Shraeyas
force-pushed
the
gh-env-secrets
branch
from
2a5c157 to
7d8c43a
Compare
|
Hi @Shraeyas! Thank you for contributing. I think it's a little confusing that there are now two GitHub tiles on the integrations page. I think it might be better if there is just one tile and users are able to choose whether they want to sync it to repository or environment secrets. What do you think? |
.env.example
Outdated
| CLIENT_ID_GITLAB= | ||
| CLIENT_ID_BITBUCKET= | ||
| CLIENT_SECRET_HEROKU= | ||
| CLIENT_SECRET_VERCEL= | ||
| CLIENT_SECRET_NETLIFY= | ||
| CLIENT_SECRET_GITHUB= | ||
| CLIENT_SECRET_GITHUB_ENVIRONMENT= |
There was a problem hiding this comment.
Does there have to be a separate environment variable? I think we might be able to reuse the current github one
There was a problem hiding this comment.
My initial thought was we can assign different permissions for the oauth keys for both the integrations, but since anyways we will be merging both GitHub and GitHub environments, we can simply reuse the GitHub client id and secrets.
Also, since we had separate integrations, the redirect URI mentioned for the tokens will have to be different.
@vmatsiiako Makes sense. We can merge both into one and give users an option to choose from both. How exactly would you like the UI to look? Should there be a drop-down to choose from the two or should there be a different tab within the tile? |
|
@Shraeyas yeah, it might be better to have a different tab, or just have it as an advanced setting where you have to choose one or the other |
Shraeyas
force-pushed
the
gh-env-secrets
branch
from
15b20ac to
549a549
Compare
|
I started testing it, and for some reason it doesn't work for me. Even though I have environments in my github repository, they are not pulled up into the Dropdown in Infisical. Do you know why this could happen? |
|
@vmatsiiako It is working fine for me. Just to be sure, I even set up the project from scratch on this branch and it is still working. If there is any other information/logs that you can share, that would be helpful.
|
|
This PR is now stale. The backend structure has changed completely due to Postgres migration |
Description 📣
Resolves #1154
Type ✨