Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-136] Issues with google sso #1035

Open
markksuite opened this issue Sep 29, 2023 · 8 comments
Open

[ENG-136] Issues with google sso #1035

markksuite opened this issue Sep 29, 2023 · 8 comments
Milestone

Comments

@markksuite
Copy link

markksuite commented Sep 29, 2023

Using latest version of infisical frontend and backend (v.0.36.2) + mongo + redis, self hosted.

When pressing "Continue with Google" button (during login procs.), infisical redirects me to: https://subdomain.mydomain.com/api/v1/sso/subdomain.mydomain.com/login/sso?token=sometokenhere.

And shows blank json response:
image

But, after I edit first part of url and delete subdomain.mydomain.com/api/v1/sso/ at the beginning of generated url (new address: https://subdomain.mydomain.com/login/sso?token=sometokenhere):
image

Infisical succesfully accepts my auth request.

I think, in self-hosted solution, app just uses $SITE_URL environmental variable twice.

ENG-136

@vmatsiiako vmatsiiako changed the title Issue on with google sso [ENG-136] Issue on with google sso Sep 29, 2023
@markksuite markksuite changed the title [ENG-136] Issue on with google sso [ENG-136] Issues with google sso Sep 29, 2023
@markksuite
Copy link
Author

Edited description (added more info) and issue title

@dangtony98
Copy link
Collaborator

Hey @markksuite,

I assume you've followed each step in the docs for Google SSO here?

I would look into the redirect URL set in GCP as well as the SITE_URL environment variable being set in your instance of Infisical.

@markksuite
Copy link
Author

@dangtony98 yes, and it works, if i remove the repeated url address

@vmatsiiako vmatsiiako added this to the v.6 milestone Oct 2, 2023
@markksuite
Copy link
Author

env
Here is my env vars (running in kube, v.0.36.2 docker image)

@markksuite
Copy link
Author

Google api:
env2

@dangtony98
Copy link
Collaborator

Awesome so we can consider this issue resolved? @markksuite

@markksuite
Copy link
Author

markksuite commented Oct 2, 2023

I still have the same issue, url is repeated twice (it works only if you manually edit url link, in browser)

@markksuite
Copy link
Author

markksuite commented Oct 2, 2023

Sorry, forget about tagging, almost every time :).
@dangtony98

@dangtony98 dangtony98 reopened this Oct 2, 2023
@vmatsiiako vmatsiiako modified the milestones: v.6, v.7 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants