Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ARIA label as CSS selector #18

Open
christophdubach opened this issue Mar 30, 2024 · 0 comments
Open

Avoid ARIA label as CSS selector #18

christophdubach opened this issue Mar 30, 2024 · 0 comments

Comments

@christophdubach
Copy link

Currently CSS selectors like nav[aria-label="page"] are used.

Since the value of the aria-label attribute should be translated, the CSS selector must be adjusted accordingly when adding another language.

nav[aria-label="page"],
nav[aria-label="Seite"],
nav[aria-label="pagina"],
nav[aria-label="foo"] {

This could lead to errors as someone could forget to make this adjustment
So it might make sense to add a class to the <nav> element instead of using aria-label as a selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant