Reconnecting to hub or using history command shows custom commands by users

[nishithshah2211]

When a user reconnects to hub or uses +history command, custom commands used by users who are mods or below are also displayed, which should not happen.

[hjpotter92]

Ideally, yes. The current code has:

local sCmd, sData = sMessage:match( "%b<> [-+*/?!#](%w+)%s?(.*)|" )

which returns false positives for messages like +1, *sorry, #some-or-other-hash-tag. It needs a more complex solution than the one you suggest in the pull request.

[nishithshah2211]

Yes, I didn't think of that at all. We can maintain a table of commands and then check if sCmd is in the table or not and proceed accordingly.

[nishithshah2211]

Are there commands that do not start with a + or ! or /? I was thinking we could use this:

local sCmd, sData = sMessage:match( "%b<> [+/!](%w+)%s?(.*)|" )

[hjpotter92]

The character set [-+*/?!#] implies that I can use ANY of those characters for the commands. So, all of the following are equivalent:

!help
+help
/help
#help
?help
*help
-help