Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a folder with subfolder fails #47

Open
humdingerb opened this issue Aug 15, 2019 · 3 comments
Open

Deleting a folder with subfolder fails #47

humdingerb opened this issue Aug 15, 2019 · 3 comments
Labels
bug hacktoberfest Issues proposed to Hacktoberfest participants

Comments

@humdingerb
Copy link
Member

Removing a folder with some files directly in it works, it doesn't if these files are in a subfolder. Then it misses the first file. For example, if you have this:

Folder/Subfolder/01.mp3
Folder/Subfolder/02.mp3
Folder/Subfolder/03.mp3

If you delete 'Folder', only 02.mp3 and 03, mp3 are deleted and Folder/Subfolder/01.mp3 remains.

I tracked it down a bit, but I'm too lame to find the fix...
It seems the pathList at https://github.com/HaikuArchives/FtpPositive/blob/master/src/FTPLooper.cpp#L733 that gets created in ListRDirList() (and maybe also RecurseDirList() ?) is missing the entries for the first file (or files, depending on the level of subdirs, I suppose).

@sdomi
Copy link

sdomi commented Dec 14, 2019

I tried reproducing the issue, but after creating the exact directory hierarchy as you have described above, FtpPositive just deletes the directory without any problems. Could you share any more info? To me, this smells more like a server than a client issue.

My test server is 220 sakamoto FTP server (Version 6.4/OpenBSD/Linux-ftpd-0.17) ready.

@humdingerb
Copy link
Member Author

I tested with a Synology DS213J. Can't tell the exact software its running, as the hardware is currently not on hand. I'll try to find that out when it's here again.

@n0toose
Copy link

n0toose commented May 1, 2020

I tested with a Synology DS213J. Can't tell the exact software its running, as the hardware is currently not on hand. I'll try to find that out when it's here again.

I tested with a Synology DS213J. Can't tell the exact software its running, as the hardware is currently not on hand. I'll try to find that out when it's here again.

Although I'd like to reproduce this as well and haven't done so yet, I suspect that the filesystem may be involved here.

@scottmc scottmc added the bug label Sep 28, 2021
@scottmc scottmc added the hacktoberfest Issues proposed to Hacktoberfest participants label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug hacktoberfest Issues proposed to Hacktoberfest participants
Development

No branches or pull requests

4 participants