Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom recipes with circuit as input dont show on JEI #2629

Open
2 tasks done
DevDyna opened this issue Dec 23, 2024 · 5 comments
Open
2 tasks done

Custom recipes with circuit as input dont show on JEI #2629

DevDyna opened this issue Dec 23, 2024 · 5 comments
Labels
1.21 type: bug Something isn't working

Comments

@DevDyna
Copy link

DevDyna commented Dec 23, 2024

Checked for existing issues

  • I have checked for existing issues, and have found none.

Tested latest version

  • I have checked that this occurs on the latest version.

GregTech CEu Version

gtceu-1.21.1-1.4.6

Minecraft Version

1.21.1 NeoForge

Recipe Viewer Installed

JEI

Environment

Singleplayer

Cross-Mod Interaction

No

Other Installed Mods

Required to reproduce this issue:
JEI

Expected Behavior

Adding a recipe to a machine that just have one slot and all of default recipes dont include circuits as input it should show info about that or just throw errors on logs

(idk if it was a bug or not)

Actual Behavior

It work but still "hidden" the circuit on jei due the machine slots / it dont support circuits as input

Steps to Reproduce

step 1:

create a datapack / install kubejs and add inside kubejs/data/<modname>/recipe/ this recipe

//just the sifter gravel recipe but with stone as input + circuit 1
new.json

step 2:

run /reload and search it on jei

image

step 3:

place a sifter correctly configured without change circuit settings and it look like that (dont execute the recipe)
image

step 4:

change the circuit setting to 1

you can see that it execute the recipe
image

Additional Information

Possible solution:

completly change circuit view on jei ( item -> texture ) and adding it a condition to show only when on recipe input still required so it can be used on custom recipes where input slots are just one

@DevDyna DevDyna added the type: bug Something isn't working label Dec 23, 2024
@krossgg krossgg added the 1.21 label Dec 27, 2024
@a-a-GiTHuB-a-a
Copy link
Contributor

can sifters even accept a circuit?

@DevDyna
Copy link
Author

DevDyna commented Jan 11, 2025

can sifters even accept a circuit?

yes (using a custom recipe using a datapack but probably work at same using kjs )

@a-a-GiTHuB-a-a
Copy link
Contributor

It's probably because the circuit uses an item slot which the sifter doesn't have. I don't think it's a GT issue.

@krossgg
Copy link
Contributor

krossgg commented Jan 12, 2025

While the circuit setting does work if you do it this way, it is not meant to. The circuit slot is supposed to count as one of the inputs, and the sifter, and cutter, for instance, do not have this second slot. However, the circuit setting does still work as a side effect of how our machines are defined.

@a-a-GiTHuB-a-a
Copy link
Contributor

Should this be closed, then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants