Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Spline tool draw a polylines with a Path -> Spline from Points node setup #2184

Open
Keavon opened this issue Jan 10, 2025 · 0 comments
Labels
Feature New feature or request Good First Issue Good for newcomers

Comments

@Keavon
Copy link
Member

Keavon commented Jan 10, 2025

Part 1

Listen to the task description in this video.

Part 2

This can be a separate PR.

  1. Create an upgrade script to transform a single existing "Spline" node, in the graph of any existing documents people have today, into a Path -> Spline from Points node pair with the point data transferred over to the Path node's geometry
  2. Delete the "Spline" node
  3. Rename the "Spline from Points" node to just "Spline"
  4. Create an upgrade script to rename the "Spline from Points" node in existing documents to "Spline"

Search the project for "document upgrade code" and you'll find all the comments relating to the upgrading scripts. The ones in portfolio_message_handler.rs, within the handler for the PortfolioMessage::OpenDocumentFileWithId message, are most relevant to read and that's likely where you'll be adding most or all the upgrading code to.

@Keavon Keavon added Feature New feature or request Good First Issue Good for newcomers labels Jan 10, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Good First Issue Good for newcomers
Projects
Status: Short-Term
Development

No branches or pull requests

1 participant