Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Escape formatting from OCR results #20

Closed
wants to merge 5 commits into from

Conversation

codingJWilliams
Copy link

Perhaps fixes #19 ?

Thoughts? One interesting idea I had was affixing a backslash before every single character - if a backslash isn't required reddit silently ignores it, but if it is, it'll nuke the formatting. This could work?

@codingJWilliams codingJWilliams requested a review from a team as a code owner May 13, 2018 16:49
It was there already, I accidentally removed it then added it back but according to code quality it should not be there
@codingJWilliams codingJWilliams changed the title Add formatting stripper Escape formatting from OCR results May 13, 2018
@DavidArchibald
Copy link

I'm against this because of two reasons:

  1. Whitespace escapes ("n" and "t" would become "\n" and "\t")
  2. Relying on Reddit to ignore extra backslashes for us is lazy and is still going to be visible in RES's raw text. Which is ugly.

@itsthejoker
Copy link
Member

This was resolved in e2c662e. Closing. Sorry Jay ☹️

@itsthejoker itsthejoker closed this Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not escape Reddit formatting characters
3 participants