-
Notifications
You must be signed in to change notification settings - Fork 13
[FEATURE] Format column names #54
Comments
This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping to make Google Data Catalog Connectors better! |
This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping to make Google Data Catalog Connectors better! |
This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping to make Google Data Catalog Connectors better! |
This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping to make Google Data Catalog Connectors better! |
What would you like to be added:
Support for column name formatting.
Why is this needed:
The Sisense BI Connector uses Entry Schemas to represent some asset fields. Data Catalog requires the
ColumnSchema
'scolumn
field to fit a specific bytes-size limit and character encoding, which is currently not supported by the connectors commons library but should be.Below changes narrow down the scope of the present feature request:
google.datacatalog_connectors.sisense.prepare.sisense_connector_strings_helper.py
withgoogle.datacatalog_connectors.commons.prepare.datacatalog_strings_helper.py
....sisense.prepare.sisense_connector_strings_helper.py
....commons.prepare.DataCatalogStringsHelper
to turnnormalize_string
into a public method....commons.prepare.BaseEntryFactory
to call...commons.prepare.DataCatalogStringsHelper.normalize_string
instead of declaring its own__normalize_string
method as it will become a duplicate....sisense.prepare.datacatalog_entry_factory.DataCatalogEntryFactory
to call...commons.prepare.DataCatalogStringsHelper.normalize_string
as thecurrent dependency will no longer exist after the refactoring.
...sisense.prepare.datacatalog_tag_factory.DataCatalogTagFactory
to call...commons.prepare.DataCatalogStringsHelper.normalize_string
as the current dependency will no longer exist after the refactoring.The text was updated successfully, but these errors were encountered: