-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we set -J and -B defaults in modern mode (after gmtbegin
)?
#703
Comments
Related to #667 , the new julia> gmtbegin("mapdraft.pdf")
julia> basemap(region = :g, frame = :auto)
julia> gmtend(show = true) |
This is an easy one. Yes you are right, it should have the same defaults. I confess that I rarely use the modern mode so these type of issues go unnoticed. If you want to give it a try, please go ahead. I'll classes start shortly (start delayed still because of the covid) and need to keep working in the new RemoteS package. Also because of this, addressing your other -B issues will take longer to address. |
No worries, thanks for all the guidance so far! Hopefully you don't have to do classes online like they are here in Australia... |
We had quite a big share of online classes but for now they will be insitu again. |
Removes some special casing of modern mode in parsee_B and parse_BJR. This does not allow J option defaults for modern mode yet. Also, this breaks some subplot code, e.g. example 2 in https://www.generic-mapping-tools.org/GMT.jl/dev/subplot/#Examples. Issue GenericMappingTools#703
Currently, when using modern mode the defaults for projection (-J) and frame (-B) are not set, for example:
It happens with the other functions as well of course (not just
basemap
). I think the defaults that are set in classic mode are quite nice, so maybe it wouldn't hurt to use them in modern mode as well? I'm not sure anything is lost by doing this: if the user wants a different projection/frame, they can still override the defaults. Also, the behaviour becomes more consistent with classic mode.I can have a go at a patch (probably not before the weekend) if you're short on time. Just thought I'd raise the point.
Cheers
The text was updated successfully, but these errors were encountered: