-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZnCharacterStreamTests #testUpToAll and #testUpToAllTwice are now failing #79
Comments
… ZnCharacterStreamTests >> testUpToAllTwice is not ...
…testUpToAllTwice, so added utf8 encoded streams to #testUpToAll (and boom) also updated #testUpToAll samples to include strings from #testUpToAllTwice ... failing tests
…treamPosition to illustrate what I think should be a bug
as of this commit [69e837d], I believe that the #upToAll: implementation is complete, however, there seem to be some issues with the #position method and ZnCharacterReadStream on UTF8 encoded streams: | string bytes stream res |
string := 'eißendeße'.
bytes := ZnUTF8Encoder new encodeString: string.
stream := (ZnCharacterReadStream on: bytes readStreamPortable).
res := stream next; next; next.
self assert: res equals: $ß.
self assert: stream position equals: 3. So will hold off until the issue is resolved.. |
…on test for completeness, reorder the samples in ZnCharacterStreamTests >> testUpToAll and fix some regressions that snuck in while working on utf8 variant
Issue #80 reports the above problem |
Will close this issue in anticipation of Issue #80 resolving the current test failures, but can be re-opened if necessary |
I switched implementations of #upToAll: and updated #testUpToAllTwice which was using See 391b3e4. |
These two tests were skipped dating back to my original port of FileSystem to GemStone and today I turned the testing back on and the tests are now failing ... so it is time for me to pay the piper and bring the #upToAll: implementation up to snuff
The text was updated successfully, but these errors were encountered: