Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to diff that only recurses if outputs are different #4

Open
ocharles opened this issue Jan 10, 2018 · 3 comments
Open

A way to diff that only recurses if outputs are different #4

ocharles opened this issue Jan 10, 2018 · 3 comments

Comments

@ocharles
Copy link

I have two derivations that are different, /nix/store/f6a70iijzdq7xzkyycqcggqdv2s77nla-HsOpenSSL-0.11.4.11.drv and /nix/store/7kmc4asp07ffp9ppihmvl0xjk6qcq2gq-HsOpenSSL-0.11.4.11.drv. However, this doesn't actually matter, because the outputs of both of these derivations are the same thing. The differences in derivation are due to how tars are fetched (different mirrors), but the result is the same due to the fixed output.

Thus while these are different derivations, they don't affect substitution. It'd be nice if nix-diff didn't consider such derivations further (just check that the outputs are the same).

@Gabriella439
Copy link
Owner

Yeah, I just ran into this issue, too. I agree that this should be fixed although I won't be able to get to it for a few weeks if that's alright

@expipiplus1
Copy link

expipiplus1 commented Jan 12, 2018 via email

@Gabriella439
Copy link
Owner

I have a quick and dirty branch up here:

https://github.com/Gabriel439/nix-diff/tree/gabriel/fixed_outputs

I'll test it more once I have another example of this at work to test drive this on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants