Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingameinfo XML] Numerous isuses after memory optimization update (2.8.14) #17772

Closed
3 tasks done
PlayfulPiano opened this issue Oct 26, 2024 · 10 comments · Fixed by GTNewHorizons/InGame-Info-XML#27
Closed
3 tasks done
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed

Comments

@PlayfulPiano
Copy link
Contributor

Your GTNH Discord Username

PlayfulPiano

Your Pack Version

2.7.0 beta 3

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Expectation

v2.8.13
image
image

The Reality

v2.8.15
image
image

Your Proposal

After the memory optimization patch for igixml, multiple aspects of the mod rendering broke completely. This includes icon textures, relative icon/text positioning, and status effect textures.

Now v2.8.15 did fix a lot of other issues that came from the patch already, but the above discrepancies are still occurring.

Below is my igixml file that I use (was planning to make a pr for the center chunk icon):

https://gist.github.com/PlayfulPiano/6e3b3ffa774b38aedcd17f6aa699566a

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@PlayfulPiano PlayfulPiano added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels Oct 26, 2024
@Lyfts
Copy link
Member

Lyfts commented Oct 27, 2024

The icon issues are addressed in GTNewHorizons/InGame-Info-XML#26

I can't really reproduce the positioning issues though, have you changed any other igi settings?
igi-
igi--

@PlayfulPiano
Copy link
Contributor Author

PlayfulPiano commented Oct 27, 2024

The icon issues are addressed in GTNewHorizons/InGame-Info-XML#26

I can't really reproduce the positioning issues though, have you changed any other igi settings? igi- igi--

This is what my actual config is set to for reference:
https://gist.github.com/PlayfulPiano/c96acfde2e4df75b7721984475a21559

@PlayfulPiano
Copy link
Contributor Author

Tested the new version, icons all work fine now but the weird icon overlap issue is still apparent. Again, only when updating from 2.8.13 to 2.8.16.

Also for the status effects, it appears only one icon shows at a time in .16?
image
image

@Lyfts
Copy link
Member

Lyfts commented Oct 27, 2024

@PlayfulPiano
Copy link
Contributor Author

@PlayfulPiano can you give https://github.com/GTNewHorizons/InGame-Info-XML/releases/tag/2.8.17-pre a try?

Just tried it, and everything looks good now. Non-vanilla effects sometimes aren't shown but that was like that prior to the memory optimization patch (and I think it might just be the toughness effect lol).

tysm
image

@PlayfulPiano
Copy link
Contributor Author

well the first line for my name is misaligned but that's much more small beans vs all the other problems lmao

@PlayfulPiano
Copy link
Contributor Author

Actually @Lyfts just developed a crash while playing, although unsure what specifically caused it (I was afk at the time).
crash-2024-10-27_18.24.22-client.txt

@PlayfulPiano
Copy link
Contributor Author

ah, appears to have happened when it started raining https://www.twitch.tv/playfulpiano/clip/SteamyJollyTigerKappaPride-jLVI8riNWBgW44ZG

@Lyfts
Copy link
Member

Lyfts commented Oct 28, 2024

@PlayfulPiano most of the remaining issues should (hopefully) be fixed in https://github.com/GTNewHorizons/InGame-Info-XML/releases/tag/2.8.18-pre

@PlayfulPiano
Copy link
Contributor Author

@PlayfulPiano most of the remaining issues should (hopefully) be fixed in https://github.com/GTNewHorizons/InGame-Info-XML/releases/tag/2.8.18-pre

Looks a lot better, ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants