Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less hacky offhand #46

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Less hacky offhand #46

wants to merge 10 commits into from

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Jan 15, 2025

WIP - better description might come later.
This is a bigger project that will attempt to make the offhand feel more like a true vanilla offhand. Allocates an actual inventory slot for the offhand and will also render a slot for it in the player inventory. Using an inventory slot for the offhand also enables us to completely remove all of the incredibly janky hotswaps.

Closes #44
Closes #41
Closes #28
Closes #39
Closes #33
Closes #37

Might also close the following but further testing is needed
#32
#20

@Dream-Master Dream-Master requested a review from a team January 15, 2025 16:56
Copy link
Member

@Caedis Caedis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking to be an amazing rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants