New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const qualifier for void** in oroModuleLaunchKernel #110

Open

KaoCC opened this issue Dec 23, 2024 · 1 comment

Labels

feature request

Collaborator

KaoCC commented Dec 23, 2024

Cross-posted:

Can we add const to void** as follows?

oroError_t OROAPI oroModuleLaunchKernel(oroFunction_t f, unsigned int gridDimX, unsigned int gridDimY, unsigned int gridDimZ, unsigned int blockDimX, unsigned int blockDimY, unsigned int blockDimZ, unsigned int sharedMemBytes, oroStream_t stream, const void *const * kernelParams, const void *const * extra);

I think this change allows us to input const-qualified parameters to oroModuleLaunchKernel.

The text was updated successfully, but these errors were encountered:

KaoCC added the feature request label

KaoCC mentioned this issue

Add const qualifier for void** in oroModuleLaunchKernel amdadvtech/Orochi#97

Closed

Collaborator

meistdan commented Dec 23, 2024 •

edited

Loading

I'm not sure about this one, but other people suggested adding const to src in oroMemcpy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment