Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oroMemcpy functions take a non-const source pointer #103

Open
KaoCC opened this issue Oct 17, 2024 · 1 comment
Open

oroMemcpy functions take a non-const source pointer #103

KaoCC opened this issue Oct 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@KaoCC
Copy link
Collaborator

KaoCC commented Oct 17, 2024 •
edited
Loading

Suggested by Johannes:

Ideally it should be const (The CUDA counterpart uses const), but the source in HIP API is not a constant pointer.

There is an effort to change the HIP API, and after that we could modify the Orochi API by adding const.
@KaoCC KaoCC added the enhancement New feature or request label Oct 17, 2024
@takahiroharada
Copy link
Collaborator

Make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KaoCC @takahiroharada