Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffx_frameinterpolation expects currentBackBuffer and currentBackBuffer_HUDLess to be identical formats #37

Open
Nukem9 opened this issue Jan 8, 2024 · 1 comment

Comments

@Nukem9
Copy link

Nukem9 commented Jan 8, 2024

Feature request.

Code asserts that currentBackBuffer and currentBackBuffer_HUDLess inputs are identical formats. I believe this isn't necessary as long as the two formats are within the same type group. None of the upscaling/fi shader code appears to rely on this assumption. (Possibly leftover code from raster -> compute refactoring?)

There's one caveat: the previous interpolation source texture is created using the back buffer's format and down the line CopyTextureRegion(prevInterpSource, inputHUDLess) gets called. Different types aren't guaranteed to be copyable.

@Filoppi
Copy link

Filoppi commented Feb 25, 2024

Attempted fix: #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants